[OpenWrt-Devel] [PATCH] ipqx0xx: add Generic subtarget

[John Crispin]

On 22/08/2019 02:59, Paul Spooren wrote:
> Both targets miss a subtarget causing an image naming style which is
> different from other all othe targets, even tho it already uses
> `x/generic/` as subfolder as if the subtarget would exist.
>
> This commit adds the Generic subtarget resulting in consistent naming.
>
>      ~/src/openwrt/openwrt/bin/targets/ipq806x/generic$ ls
>      openwrt-ipq806x-generic-netgear_d7800-initramfs-uImage
>      openwrt-ipq806x-generic-netgear-d7800.manifest
>      openwrt-ipq806x-generic-netgear_d7800-squashfs-factory.img
>      openwrt-ipq806x-generic-netgear_d7800-squashfs-sysupgrade.bin

Why would we need to have the generic in the name if there is no other 
non-generic subtarget ?

     John


> CC: John Crispin <john at phrozen.org>
>
> Signed-off-by: Paul Spooren <mail at aparcar.org>
> ---
>   target/linux/ipq40xx/Makefile          | 1 +
>   target/linux/ipq40xx/generic/target.mk | 1 +
>   target/linux/ipq806x/Makefile          | 1 +
>   target/linux/ipq806x/generic/target.mk | 1 +
>   4 files changed, 4 insertions(+)
>   create mode 100644 target/linux/ipq40xx/generic/target.mk
>   create mode 100644 target/linux/ipq806x/generic/target.mk
>
> diff --git a/target/linux/ipq40xx/Makefile b/target/linux/ipq40xx/Makefile
> index 9b78d1f1bf..9e26b277fa 100644
> --- a/target/linux/ipq40xx/Makefile
> +++ b/target/linux/ipq40xx/Makefile
> @@ -7,6 +7,7 @@ FEATURES:=squashfs fpu ramdisk nand
>   CPU_TYPE:=cortex-a7
>   CPU_SUBTYPE:=neon-vfpv4
>   MAINTAINER:=John Crispin <john at phrozen.org>
> +SUBTARGETS:=generic
>   
>   KERNEL_PATCHVER:=4.19
>   
> diff --git a/target/linux/ipq40xx/generic/target.mk b/target/linux/ipq40xx/generic/target.mk
> new file mode 100644
> index 0000000000..f5cb1fb19b
> --- /dev/null
> +++ b/target/linux/ipq40xx/generic/target.mk
> @@ -0,0 +1 @@
> +BOARDNAME:=Generic
> diff --git a/target/linux/ipq806x/Makefile b/target/linux/ipq806x/Makefile
> index cd0e8b82ea..19ed015ebc 100644
> --- a/target/linux/ipq806x/Makefile
> +++ b/target/linux/ipq806x/Makefile
> @@ -9,6 +9,7 @@ FEATURES:=squashfs nand fpu ramdisk
>   CPU_TYPE:=cortex-a15
>   CPU_SUBTYPE:=neon-vfpv4
>   MAINTAINER:=John Crispin <john at phrozen.org>
> +SUBTARGETS:=generic
>   
>   KERNEL_PATCHVER:=4.14
>   
> diff --git a/target/linux/ipq806x/generic/target.mk b/target/linux/ipq806x/generic/target.mk
> new file mode 100644
> index 0000000000..f5cb1fb19b
> --- /dev/null
> +++ b/target/linux/ipq806x/generic/target.mk
> @@ -0,0 +1 @@
> +BOARDNAME:=Generic

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel