[OpenWrt-Devel] [PATCH] ath79: add support of Netgear WNR3800 (Ch)

[Adrian Schmutzler]

> Maybe DEVICE_VARIANT := CH is a better choice, since it is the same device.

Well, is it a variant? If yes, CH implies Switzerland to me, which most probably is wrong.
Despite, if you decide to use CH as variant, you would have to introduce hyphens to device definition name and compatible, i.e. "netgear,wndr3800-ch".

If the CH stands for China, as I've also read when googleing, I would prefer having CN here. This will then very much depend upon whether the CH is used officially somewhere or whether it's just an invention of previous OpenWrt versions ... (Where in the latter case I'd actually change to CN as we did for other devices ...).

Best

Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190807/9de30377/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel