[OpenWrt-Devel] [PATCH v2 4/5] ath79: add support for Netgear WNR1000 v2

[Adrian Schmutzler]

Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org] On Behalf Of Michal Cieslakiewicz
> Sent: Dienstag, 6. August 2019 16:06
> To: openwrt-devel at lists.openwrt.org
> Cc: Adrian Schmutzler <mail at adrianschmutzler.de>
> Subject: [OpenWrt-Devel] [PATCH v2 4/5] ath79: add support for Netgear WNR1000 v2
> 
> This patch adds ath79 support for Netgear WNR1000v2.
> Router was previously supported by ar71xx target only.
> Note: this is a 4_32 device with limited upgrade capabilities.
> 

...

> diff --git a/target/linux/ath79/dts/ar7240_netgear_wnr1000-v2.dts b/target/linux/ath79/dts/ar7240_netgear_wnr1000-v2.dts
> new file mode 100644
> index 0000000000..a9eabb5a88
> --- /dev/null
> +++ b/target/linux/ath79/dts/ar7240_netgear_wnr1000-v2.dts
> @@ -0,0 +1,207 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +
> +#include "ar7240.dtsi"
> +
> +/ {
> +	model = "Netgear WNR1000 v2";
> +	compatible = "netgear,wnr1000-v2", "qca,ar7240";

compatible before model ...

In general, it looks to me like you can exploit wnr612-v2.dtsi here.
LEDs will require some care, but almost everything else is shared.
In that context, one might think whether there is a better name for the shared DTSI then ...

For the image Makefile, the same comments as in previous patch are relevant.

Best

Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190806/6eae5a1d/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel