[OpenWrt-Devel] [PATCH 1/2] base-files: make USE_PROCD=1 default

[Alberto Bursi]

On 02/08/19 18:18, Kevin 'ldir' Darbyshire-Bryant wrote:
>
>> On 2 Aug 2019, at 16:00, Hannu Nyman <hannu.nyman at iki.fi> wrote:
>>
>> Hauke Mehrtens kirjoitti 2.8.2019 klo 17.42:
>>> On 7/23/19 3:37 PM, Petr Štetiar wrote:
>>>> Transition period for init script migration was long enough, let's
>>>> make USE_PROCD=1 default now so there's enough time to convert the
>>>> remaining services/init scripts for the next release.
>>>>
>>>> Signed-off-by: Petr Štetiar <ynezz at true.cz>
>>>> ---
>>>>   package/base-files/files/etc/rc.common | 113 ++++++++++---------------
>>>>   1 file changed, 47 insertions(+), 66 deletions(-)
>>>>
>>> Do you know how many packages in the package feed and the main
>>> repository are still not using procd?
>>>
>>> External repositories, not the package feed, will probably be affected
>>> most, but I think we do not have to care and there were many years to
>>> convert.
>>>
>>> Acked-by: Hauke Mehrtens <hauke at hauke-m.de>
>>>
>>> Hauke
>>>
>> I do not remember seeing ever a general call for converting the old packages to using procd. In that sense this proposed change to switch the default comes a bit surpise.
>>
>> Quick search in the packages feed repo reveals that there are 281 instances of "/etc/rc.common" and only 205 instances of USE_PROCD. So, likely about 75 packages in the packages feed repo only are using the old syntax without procd.
>>
>> Has a decision been made to declare the old-style init file invalid? Will it be possible to still use the syntax? What is the new "override" to indicate the usage of the old syntax?
>>
>> Or will the proposed change disable the packages using the old init file syntax totally?
> My reading of the change is that old syntax is basically dropped.
>
> Wish for:  We should be using procd and to that end I started looking at converting the ‘important to me’ packages: ddns & miniupnpd.
>
> Real life: Documentation is confusing vs real life which is just plain different. See adblock startup script as an excellent example of **** that just isn’t documented.
>
> I gave up and left the process feeling very angry.
>
>
> KDB
>

I had a look at that init script and I see that more or less everything 
it does is documented in the wiki 
https://openwrt.org/docs/guide-developer/procd-init-scripts

and the example here 
https://openwrt.org/docs/guide-developer/procd-init-script-example


Main things missing are the boot() function and the use of 
EXTRA_COMMANDS and EXTRA_HELP to add more commands you can find as 
functions under the normal ones.

I think it should still be enough to port over the ddns as it's 
basically just starting and stopping an external script, but for 
miniupnpd you would probably have to move

all the logic from the initscript to an external helper script you call 
from procd, similar to what ddns package does.


Although yes I agree on the concept, procd has jails and other 
functionality that isn't documented anywhere.

I've seen commits for stuff but not found packages using it.


-Alberto


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel