[OpenWrt-Devel] [PATCH v2] ath79: add support for OCEDO Ursus

[Petr Štetiar]

markus.scheck1 at gmail.com <markus.scheck1 at gmail.com> [2019-03-21 16:43:27]:

Hi,

> +			label = "ursus:green:wlan2";
> +			label = "ursus:green:wlan5";

could we please make it wlan2g and wlan5g in order to stay consistent?

I found this old PR[1] for ar71xx, which makes me wonder if the stuff bellow
is correct.

> +&mdio0 {
> +	status = "okay";
> +
> +	phy1: ethernet-phy at 1 {
> +		reg = <1>;
> +	};
> +

In that ar71xx code it seems, that phy2 is connected through GMAC1/SGMII. Can
you please explain in your commit message what is connected where in more
details?

> +	phy2: ethernet-phy at 2 {
> +		reg = <2>;
> +	};
> +};
> +
> +&eth0 {
> +	status = "okay";

add newline here

> +	mtd-mac-address = <&art 0x00>;
> +	phy-handle = <&phy1>;
> +	pll-data = <0xa6000000 0x80000101 0x80001313>;

	pll-data = <0xae000000 0xa0000101 0xa0001313>;

what is expected phy-mode here?

> +&eth1 {
> +	status = "okay";

add newline here

> +	mtd-mac-address = <&art 0x12>;

	mtd-mac-address = <&art 0xc>; ?

> +	phy-handle = <&phy2>;
> +	pll-data = <0x3000101 0x101 0x1313>;

what is expected phy-mode here?

	pll-data = <0x0300000 0x101 0x1313>;

1. https://github.com/openwrt/openwrt/pull/1016/commits/6bc138ec46ce956783aba7f8c83608982030a8be

-- ynezz


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel