[OpenWrt-Devel] [PATCH v2] kernel: revert evil EVIL module stripping patches

[Kevin Darbyshire-Bryant]

> On 27 Oct 2018, at 23:29, Daniel Santos <daniel.santos at pobox.com> wrote:
> 
> Don't ever EVER do this!  It has taken me several hours to discover the
> underlying cause of my modules being mysteriously stripped, despite
> having made certain CONFIG_MODULE_STRIP was not enabled.  This is a
> truely horrendous and dispicable way to strip modules.  First of all, it
> is insideious and activates any time you aren't profiling.  Second, it
> also brakes kmemleak.
> 
> Never go behind the back of the programmer / admin / hacker and do
> things like this without their permission.  In Free and Open Source
> Software, we do not force things to happen that the user has not elected
> to have done.  If you really want excessive stripping for that extra 4k,
> then add a distinct option to remove all symbols.
> 
> Signed-off-by: Daniel Santos <daniel.santos at pobox.com>

I suggest that a less emotionally charged commit title & message would be more appropriate.

PS: ‘breaks’ not ‘brakes'


Cheers,

Kevin D-B

012C ACB2 28C6 C53E 9775  9123 B3A2 389B 9DE2 334A

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel