[OpenWrt-Devel] [PATCH 2/5] apm821xx: set uart compatible to ns16750

Christian Lamparter chunkeey at gmail.com
Mon Oct 15 14:00:06 EDT 2018


The APM821XX/PPC460EX datasheet mentions:
"Register compatibility with 16750 register set"

Signed-off-by: Christian Lamparter <chunkeey at gmail.com>
---
 target/linux/apm821xx/dts/apm82181.dtsi | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/target/linux/apm821xx/dts/apm82181.dtsi b/target/linux/apm821xx/dts/apm82181.dtsi
index be8ace9207..79596da672 100644
--- a/target/linux/apm821xx/dts/apm82181.dtsi
+++ b/target/linux/apm821xx/dts/apm82181.dtsi
@@ -306,24 +306,29 @@
 			};
 
 			UART0: serial at ef600300 {
-				device_type = "serial";
-				compatible = "ns16550";
+				/*
+				 * AMCC's BSP u-boot scans for the "ns16550"
+				 * compatible, without it, u-boot wouldn't
+				 * set the "clock-frequency" which is required.
+				 *
+				 * However, the hardware documentation lists:
+				 * "Register compatibility with 16750 register set"
+				 */
+				compatible = "ns16750", "ns16550";
 				reg = <0xef600300 0x00000008>;
 				virtual-reg = <0xef600300>;
 				clock-frequency = <0>; /* Filled in by U-Boot */
-				current-speed = <0>; /* Filled in by U-Boot */
 				interrupt-parent = <&UIC1>;
 				interrupts = <0x01 IRQ_TYPE_LEVEL_HIGH>;
 				status = "disabled";
 			};
 
 			UART1: serial at ef600400 {
-				device_type = "serial";
-				compatible = "ns16550";
+				/* same "ns16750" as with UART0 */
+				compatible = "ns16750", "ns16550";
 				reg = <0xef600400 0x00000008>;
 				virtual-reg = <0xef600400>;
 				clock-frequency = <0>; /* Filled in by U-Boot */
-				current-speed = <0>; /* Filled in by U-Boot */
 				interrupt-parent = <&UIC0>;
 				interrupts = <0x01 IRQ_TYPE_LEVEL_HIGH>;
 				status = "disabled";
-- 
2.19.1


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list