[OpenWrt-Devel] [PATCH v2] ath79: add support for TP-Link Archer A7

[David Bauer]

Hello Karl,

just as a heads-up for your v3:

On 23.11.18 22:00, Karl-Felix Glatzer wrote:
> --- a/target/linux/ath79/image/common-tp-link.mk
> +++ b/target/linux/ath79/image/common-tp-link.mk
> @@ -39,6 +39,15 @@ define Build/mktplinkfw-combined
>  	@mv $@.new $@
>  endef
>  
> +define Build/uImageArcher
> +	${STAGING_DIR_HOST}/bin/mkimage \
> +		-A $(LINUX_KARCH) \
> +		-O linux -T kernel \
> +		-C $(1) -a $(KERNEL_LOADADDR) -e $(if $(KERNEL_ENTRY),$(KERNEL_ENTRY),$(KERNEL_LOADADDR)) \
> +		-n '$(call toupper,$(LINUX_KARCH)) OpenWrt Linux-$(LINUX_VERSION)' -d $@ $@.new
> +	@mv $@.new $@
> +endef
> +

This was added in
https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=946ffe470d923fdde53db68592437194e0c276fc

> --- a/target/linux/ath79/image/generic-tp-link.mk
> +++ b/target/linux/ath79/image/generic-tp-link.mk
> @@ -1,5 +1,21 @@
>  include ./common-tp-link.mk
>  
> +define Device/tplink_archer-a7-v5
> +  $(Device/tplink)

Added a definition for the safeloader-uimage with the same commit, replace

$(Device/tplink)

with

$(Device/tplink-safeloader-uimage)

> +  ATH_SOC := qca9563
> +  DEVICE_TITLE := TP-LINK Archer A7 v5
> +  DEVICE_PACKAGES := kmod-usb-core kmod-usb2 kmod-usb-ledtrig-usbport kmod-ath10k-ct ath10k-firmware-qca988x-ct
> +  SUPPORTED_DEVICES := tplink,archer-a7-v5
> +  BOARDNAME := ARCHER-A7-V5
> +  TPLINK_BOARD_ID := ARCHER-A7-V5
> +  IMAGE_SIZE := 15104k
> +  KERNEL := kernel-bin | append-dtb | lzma | uImageArcher lzma

Can be dropped, defined in tplink-safeloader, inherited by
tplink-safeloader-uimage

> +  IMAGE/sysupgrade.bin := append-rootfs | tplink-safeloader sysupgrade | \
> +        append-metadata | check-size $$$$(IMAGE_SIZE)

Can be dropped also. tplink-safeloader is missing the size check, this
is already performed within tplink-safeloader.c

> +  IMAGE/factory.bin := append-rootfs | tplink-safeloader factory

Can be dropped also.

Best wishes
David

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel