[OpenWrt-Devel] [PATCH] ramips: add support for Skylab SKW92A in EVB

[Rafał Miłecki]

On Wed, 14 Nov 2018 at 22:19, Russell Senior <russell at personaltelco.net> wrote:
> diff --git a/target/linux/ramips/dts/SKW92A.dts b/target/linux/ramips/dts/SKW92A.dts
> new file mode 100644
> index 0000000000..7bf9dcae53
> --- /dev/null
> +++ b/target/linux/ramips/dts/SKW92A.dts
> @@ -0,0 +1,118 @@
> +/dts-v1/;
> +
> +#include "mt7628an.dtsi"
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>

Please specify a license using SPDX header, ideally GPL 2.0 + MIT *if*
you are OK with that, something like:
// SPDX-License-Identifier: GPL-2.0-or-later OR MIT

For a reference see e.g. target/linux/ath79/dts/* files


> +&spi0 {
> +       status = "okay";
> +
> +       m25p80 at 0 {
> +               compatible = "jedec,spi-nor";
> +               reg = <0>;
> +               spi-max-frequency = <10000000>;
> +               m25p,chunked-io = <32>;
> +
> +               partitions {
> +                       compatible = "fixed-partitions";
> +                       #address-cells = <1>;
> +                       #size-cells = <1>;
> +
> +                       partition at 0 {
> +                               label = "u-boot";
> +                               reg = <0x0 0x30000>;
> +                               read-only;
> +                       };
> +
> +                       partition at 30000 {
> +                               label = "u-boot-env";
> +                               reg = <0x30000 0x10000>;
> +                               read-only;
> +                       };
> +
> +                       factory: partition at 40000 {
> +                               label = "factory";
> +                               reg = <0x40000 0x10000>;
> +                               read-only;
> +                       };
> +
> +                       partition at 50000 {
> +                               label = "firmware";
> +                               reg = <0x50000 0xfb0000>;
> +                       };

Does the "firmware" partition use uimage-fw parser? Do you see something like:
2 uimage-fw partitions found on MTD device firmware
?

Can you please add
compatible = "netgear,uimage";
and test/see if that works correctly, please?

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel