[OpenWrt-Devel] [PATCH] ath79: Add support for Ubiquity Bullet M2HP

[Petr Štetiar]

Lech Perczak <lech.perczak at gmail.com> [2018-11-15 19:30:00]:

Hi,

> Just a couple of remarks inline, based on my knowledge about XM series.

thanks for the review!

> > +	ubnt,bullet-m2hp|\
>
> I'd call it ubnt,bullet-m-xw, as this patch will very likely support
> Bullet-M5HP also.

Ok

> > +		link4 {
> > +			label = "ubnt:green:link4";
> > +			gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
> > +		};
> > +	};
> > +};
> 
> Shouldn't those LEDs be defined in ar9342_ubnt_xw.dtsi?
> AFAIK all XW boards (Bullet, Nano, Rocket) use same LED configurations, like
> in XM target also.

It's hard for me to add support for something I don't have on the table and
can't test it at least quickly, so it's hard to guess what should be
common and share stuff and what's separate for each device.

> Please take a look at ath79 device tree for XM boards and for board file for
> XW in ar71xx.

I did, but wasn't smart from that anyway. I would need more experience with
those device to understand the differencies.

> > +  DEVICE_TITLE := Ubiquiti Bullet M2HP
>
> Same as before, I'd call it ubnt_bullet-m-xw, as this patchset should
> automatically support Bullet-M5HP also.

Ok so it might be safe to change it to `Ubiquiti Bullet M2 and M5 HP (XW)` ?

-- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel