[OpenWrt-Devel] [RFC PATCH] build: re-enable parallelism for mksquashfs

[Stijn Segers]

Op do, 8 nov 2018 om 2:20 , schreef Daniel Santos 
<daniel.santos at pobox.com>:
> On 11/07/2018 01:52 PM, Felix Fietkau wrote:
>>  On 2018-11-05 00:19, Daniel Santos wrote:
>>>  This was disabled by commit 
>>> dcd0e4a6727611f03eb3d3a75f073235f5f1229c due
>>>  to a threading bug back in 2009.  The specifics of the bug are not 
>>> given
>>>  in the commit message and squashfs-tools has had several updates 
>>> to it's
>>>  parallelism since this time.  There are currently no open issues 
>>> related
>>>  to parallelism in their issue tracker:
>>>  https://github.com/plougher/squashfs-tools/issues
>>> 
>>>  It now "works for me" with 16 threads, and while this is a 
>>> terrible test
>>>  for a race condition I still propose we remove this work-around
>>>  unless and until we have specific knowledge of a current bug.
>>> 
>>>  Signed-off-by: Daniel Santos <daniel.santos at pobox.com>
>>  Are the images still reproducible after that change?
>>  If I remember correctly, threading would break that.
>> 
>>  - Felix
>> 
> 
> Hello.  I'm not sure what you mean by the images being reproducible.

Reproducible means you can compile twice (or more) and it will result 
in identical (bit by bit, same checksum) binaries every time.

Multithreading apparently broke that, as Felix stated. While 
reproducibility might not be an issue for you personally, I believe 
it's one of the project's goals - it's a way to ensure the builds that 
are publicly available have not been tampered with.

Stijn

> [...]
> 
> Daniel
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel