[OpenWrt-Devel] [PATCH packages] php7: add package dependency on zoneinfo-core

[Rafał Miłecki]

On 2018-06-24 21:39, Michael Heimpold wrote:
> Am Sonntag, 24. Juni 2018, 19:40:53 CEST schrieb John Crispin:
>> On 24/06/18 10:19, Rafał Miłecki wrote:
>> > From: Rafał Miłecki <rafal at milecki.pl>
>> >
>> > Having "select PACKAGE_zoneinfo-core" wasn't enough for builds without
>> > php7-cli=y or php7-cgi=y. It didn't result in installing zoneinfo-core
>> > when using "opkg install" (during runtime or when building images with
>> > CONFIG_TARGET_PER_DEVICE_ROOTFS).
>> >
>> > Missing zoneinfo results in PHP fatal errors, e.g.:
>> > Fatal error: DateTime::createFromFormat(): Timezone database is corrupt -
>> > this should *never* happen!
>> >
>> > For years users were told to manually install zoneinfo-core package.
>> > This problem was hidden for some time (including 17.01 release) due to
>> > disabled support for CONFIG_PHP7_SYSTEMTZDATA. It's now back as support
>> > for --with-system-tzdata was enabled again.
>> >
>> > The proper solution is to simply make php7 package depend on
>> > zoneinfo-core when PHP7_SYSTEMTZDATA is used.
>> >
>> > Fixes: 84e5012e8853 ("php7: re-enable system timezone data usage")
>> > Signed-off-by: Rafał Miłecki <rafal at milecki.pl>
>> 
>> php7 is part of the feed, please post a PR on github. the ML is
>> unfortunately only for trunk
> 
> this is true, but since I'm reading this list too and the patch is 
> correct
> I picked it up - no need to open a PR - hope this is ok for all :-)

Thanks!

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/listinfo/openwrt-devel