[OpenWrt-Devel] [PATCH] ath79: ar71xx create a separate driver for ar71xx pci interrupt controller.

Dmitry Tunin hanipouspilot at gmail.com
Wed Aug 22 01:08:28 EDT 2018


> > They are similar. I used that code as an example, but the
> > irq-ath79-pci has your mask/unmask for pci with reading the registers.
> > It is possible to make one driver for both, but is it really needed?
> It helps reducing code duplication.

If we completely drop that PCI_CORE IRQ that we are not using anyway,
I see no reason why we can't
define 2 subnodes or the reset controller with the same irq-ath79-misc driver.
We'll need only to set PCI IRQs to 0-2 instead of 1-3. That's all.

After some other feedback is received, I can do the change.

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list