[OpenWrt-Devel] [LEDE-DEV] [PATCH 1/9] hwmon-coretemp: add thermal monitor for Core/Core2/Atom

[Philip Prindeville]

> On Oct 22, 2017, at 11:57 PM, Felix Fietkau <nbd at nbd.name> wrote:
> 
> On 2017-10-23 05:50, Yousong Zhou wrote:
>> On 23 October 2017 at 04:21, Zoltan HERPAI <wigyori at uid0.hu> wrote:
>>> From: Philip Prindeville <philipp at redfish-solutions.com>
>>> 
>>> Signed-off-by: Philip Prindeville <philipp at redfish-solutions.com>
>>> ---
>>> package/kernel/linux/modules/hwmon.mk | 15 +++++++++++++++
>>> 1 file changed, 15 insertions(+)
>>> 
>>> diff --git a/package/kernel/linux/modules/hwmon.mk b/package/kernel/linux/modules/hwmon.mk
>>> index ed05cae..ae1a004 100644
>>> --- a/package/kernel/linux/modules/hwmon.mk
>>> +++ b/package/kernel/linux/modules/hwmon.mk
>>> @@ -108,6 +108,21 @@ endef
>>> $(eval $(call KernelPackage,hwmon-nct6775))
>>> 
>>> 
>>> +define KernelPackage/hwmon-coretemp
>>> +  TITLE:=Intel Core/Core2/Atom thermal monitoring support
>>> +  KCONFIG:=CONFIG_SENSORS_CORETEMP
>>> +  FILES:=$(LINUX_DIR)/drivers/hwmon/coretemp.ko
>>> +  AUTOLOAD:=$(call AutoProbe,coretemp)
>>> +  $(call AddDepends/hwmon, at TARGET_x86)
>>> +endef
>>> +
>>> +define KernelPackage/hwmon-coretemp/description
>>> + Kernel module for Intel Core/Core2/Atom thermal monitor chip
>>> +endef
>>> +
>>> +$(eval $(call KernelPackage,hwmon-coretemp))
>>> +
>>> +
>> 
>> This module is already builtin for x86/64 subtarget.  And since it's a
>> target-specific module, maybe we should move this to x86/modules.mk
> I don't think we should have this as a module at all. If this is needed
> for x86/generic as well, simply enable it in the kernel config there.
> 
> - Felix


And indeed, that’s why I closed PR #1470 and opened #1471 instead:

https://github.com/lede-project/source/pull/1471

if we’re all agreed this is the way to go, can someone please merge it?

Thanks,

-Philip
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel