[OpenWrt-Devel] [PATCH packages] pptpd: run service in foreground for procd compatibility

[Luka Perkov]

Hi Rafał,

On Mon, Sep 26, 2016 at 07:59:30AM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal at milecki.pl>
> 
> To have service working nicely with procd it should be running in the
> foreground. Otherwise it's not possible to e.g. stop it with the init.d
> script. Luckily for us pptpd has a simple switch that allows it.
> 
> Signed-off-by: Rafał Miłecki <rafal at milecki.pl>
> Fixes: 15e7f611afb ("pptpd: convert init script to procd")
> ---
> Hi Luka,
> 
> This pptpd package with broken procd compatibility has been also backported
> to the for-15.05 branch. Can you apply this fix to for-15.05 as well, please?

Thank you for the patch. We are using for quite a while GitHub pull
request workflow for all packages in the feeds. Please take a look at
the documentation:

https://github.com/openwrt/packages/blob/master/CONTRIBUTING.md

That said, can you make a pull request?

Thanks,
Luka

> ---
>  net/pptpd/files/pptpd.init | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/pptpd/files/pptpd.init b/net/pptpd/files/pptpd.init
> index 0d18aa1..294b00f 100644
> --- a/net/pptpd/files/pptpd.init
> +++ b/net/pptpd/files/pptpd.init
> @@ -67,6 +67,6 @@ start_service() {
>  	ln -sfn $CHAP_SECRETS /etc/ppp/chap-secrets
>  
>  	procd_open_instance
> -	procd_set_param command $BIN -c $CONFIG -o $OPTIONS_PPTP
> +	procd_set_param command $BIN -c $CONFIG --fg -o $OPTIONS_PPTP
>  	procd_close_instance
>  }
> -- 
> 2.9.3
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel