[OpenWrt-Devel] [LEDE-DEV] [PATCH netifd 3/3] interface-event: Don't dequeue hotplug event in case of interface reload event

[Felix Fietkau]

On 2016-09-13 14:33, Hans Dedecker wrote:
> Dropping hotplug event in case of interface reload results into hotplug scripts
> not being being run for the interface and thus external actors not being informed
> about the actual state of the interface.
> 
> This is clearly visible if the interface auto parameter is set to disabled for
> multiple interfaces resulting into no hotplug down event for all interfaces.
> 
> Therefore don't flush the interface hotplug queue in case an interface reload
> event is observed.
I have some doubt about this. What use is the reload event to hotplug
scripts? As far as I can tell there is no guarantee that the interface
is in a well defined state when this event is emitted. For reloads that
imply an up/down cycle, the regular events should suffice. For reloads
that affect the state without making the interface go through up/down,
we could maybe have a separate event. Am I missing something?

- Felix
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel