[OpenWrt-Devel] [PATCH v3] ramips: Add support for Xiaomi MiWiFi Nano

John Crispin john at phrozen.org
Thu Mar 17 13:50:57 EDT 2016



On 17/03/2016 17:38, Reinhard Max wrote:
> Hi,
> 
> On Sun, 13 Mar 2016 at 22:22, Noble Pepper wrote:
> 
>> +    gpio-export {
>> +        compatible = "gpio-export";
>> +        #size-cells = <0>;
>> +
>> +        gpio11 {
>> +            /* blue led */
>> +            gpio-export,name = "gpio11";
>> +            gpio-export,direction_may_change = <1>;
>> +            gpio-export,output = <1>;
>> +            gpios = <&gpio0 11 0>;
>> +        };
>> +
>> +        gpio37 {
>> +            /* red led */
>> +            gpio-export,name = "gpio37";
>> +            gpio-export,direction_may_change = <1>;
>> +            gpio-export,output = <1>;
>> +            gpios = <&gpio1 5 0>;
>> +        };
>> +
>> +        gpio44 {
>> +            /* yellow led */
>> +            gpio-export,name = "gpio44";
>> +            gpio-export,direction_may_change = <1>;
>> +            gpio-export,output = <1>;
>> +            gpios = <&gpio1 12 0>;
>> +        };
>> +    };
> 
> shouldn't LEDs be represented as what they really are in the device tree
> (compatible = "gpio-leds";) rather than exported GPIOs.
> 
> 
> cu
>     Reinhard


i missed that, please send a patch to fix the dts file i merged

	John

> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list