[OpenWrt-Devel] [PATCH] ramips: Add support for Xiaomi MiWiFi Nano

[Karl Palsson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Minor comments...

Noble Pepper <openwrtmail at noblepepper.com> wrote:
> Xiaomi MiWiFi Nano is based on Mediatek MT7628 with 64MB ram 16
> MB flash
> 
> Signed-off-by: Noble Pepper <openwrtmail at noblepepper.com>
> ---
>  package/boot/uboot-envtools/files/ramips           |  3 +-
>  .../linux/ramips/base-files/etc/board.d/02_network |  1 +
>  target/linux/ramips/base-files/lib/ramips.sh       |  3 +
>  .../ramips/base-files/lib/upgrade/platform.sh      |  1 +
>  target/linux/ramips/dts/MIWIFI-NANO.dts            | 70 ++++++++++++++++++++++
>  target/linux/ramips/image/Makefile                 |  5 ++
>  target/linux/ramips/mt7628/profiles/miwifinano.mk  | 18 ++++++

Shouldn't the profile here be "xiaomi.mk" ? normally it seems
tthat you have a profile for all the vendor boards, not a
separate file for each board.

>  7 files changed, 100 insertions(+), 1 deletion(-)
>  create mode 100644 target/linux/ramips/dts/MIWIFI-NANO.dts
>  create mode 100644 target/linux/ramips/mt7628/profiles/miwifinano.mk
> 
> diff --git a/package/boot/uboot-envtools/files/ramips
> b/package/boot/uboot-envtools/files/ramips index
> 53cf9d3..a759bcc 100644
> --- a/package/boot/uboot-envtools/files/ramips
> +++ b/package/boot/uboot-envtools/files/ramips
> @@ -23,7 +23,8 @@ linkits7688 | \
>  linkits7688d | \
>  wsr-600 | \
>  wsr-1166 | \
> -br6425)
> +br6425 | \
> +miwifi-nano)
>  	ubootenv_add_uci_config "/dev/mtd1" "0x0" "0x1000" "0x10000"
>  	;;
>  esac
> diff --git
> a/target/linux/ramips/base-files/etc/board.d/02_network
> b/target/linux/ramips/base-files/etc/board.d/02_network index
> dc9b5b2..4b65d36 100755
> --- a/target/linux/ramips/base-files/etc/board.d/02_network
> +++ b/target/linux/ramips/base-files/etc/board.d/02_network
> @@ -68,6 +68,7 @@ ramips_setup_interfaces()
>  	firewrt|\
>  	hlk-rm04|\
>  	miwifi-mini|\
> +	miwifi-nano|\
>  	mt7621|\
>  	mt7628|\
>  	mzk-750dhp|\
> diff --git a/target/linux/ramips/base-files/lib/ramips.sh
> b/target/linux/ramips/base-files/lib/ramips.sh index
> 815765a..6abda92 100755
> --- a/target/linux/ramips/base-files/lib/ramips.sh
> +++ b/target/linux/ramips/base-files/lib/ramips.sh
> @@ -250,6 +250,9 @@ ramips_board_detect() {
>  	*"MiWiFi Mini")
>  		name="miwifi-mini"
>  		;;
> +	*"MiWiFi-Nano")
> +		name="miwifi-nano"

Is there a particular reason to have the "-" in MiWiFi-Nano? It's
not there for the Mini, and doesn't appear in any of Xiaomi's
literature. Same for the .dts file.

Cheers,
Karl P

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJW5IRMAAoJEBmotQ/U1cr24NkP+gOGUUDI+ZZl36euytfq+d3N
RGsFGcWrjO2OxNJterMsdJByd/h9HOEGra+03pk327723d7o/LAVFKIWxxzApua9
SdoJvrQoM2uIevTg8HvgjM9rUsthI/RPAezl0LlQA5ZnK0MMAyXZ8vA6vH6EcQq4
kvIx9+7t2383v/BxeYXmMlNbtrPCjjzS7JSrFVCyJIB+ODieStWImtR1RY6E9K0b
vxWnkPl0alAt4AdqwnYoZ0m1OzLrybK9kmvKESTsNxExEaFPoD/pGXMNovwiHCj5
iQURsc/lEAqVaIGy+Kkzw3GymlLe1AfY+LVRkuqmyJ1m+vw54wLpdr+FHW+qgMDU
cQeL8IPYe3hvl5Bl3kpp/wQ6DgIKoLJxzldwh23dsdZv+GvyqwXHpETKeT8xv5pd
ZTQnoeD2CvZkpgCMLpXPw2kdusK+CxM98yXA5HtW+t/gcZr3q8oxHhpEfDU+7GK0
/oeut9fwNE+LoKKbN2kK1nDT9Octc6OP/V+sfe9F19kJylEXdZy4PjE7Fjcc+JSh
TZJGXEdhACcreMtz1VlrXoVehrFvcEQ1Xh7YXag+cKbeZWYwTjQcr9hkX+jlp1io
L2kjsS8M81wtFUgNvP5o/7DfYGRbZKpBdx5ANpeSvUV9ouH7Fm9X4AAkiIw56yyt
bMwR+SeOHyDz9UJQNzxf
=cewh
-----END PGP SIGNATURE-----
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel