[OpenWrt-Devel] [PATCH] base-files: For sysfixtime use hwclock if RTC available

Holger Levsen holger at layer-acht.org
Sun Jan 10 06:48:16 EST 2016


Hi,

On Sonntag, 10. Januar 2016, Daniel Dickinson wrote:
> I had assumed it was automatic detection, (hence the comments about
> Patchwork), not something someone has added as their own personal
> excessively OCD-esque requirements.

I follow this list very loosely (= I read the mails very quickly if at all) 
and after your 3 mails about this I looked at said patch of yours for half a 
second and saw the whitespace problem.

These are really easy to spot if you are used to doing code reviews. No OCD 
requirements needed.

How about you just fix that patch and move on?

Whitespace inconsistencies are teh pain.


cheers,
	Holger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20160110/0cba0e49/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list