[OpenWrt-Devel] [PATCH V2 3/3] ramips: Add build files for HiWiFi HC5x61 models

[Piotr Dymacz]

Hello,

Just three comments:

1. Please, use tabs as in all other profile files (I didn't spot that
before, sorry).
2. Keep two empty lines between different boards profiles definitions,
take target/linux/ramips/rt305x/profiles/d-link.mk as example.
3. You have selected a lot of external packages. IMHO, default profile
should include only basic and needed for general "router"
functionality packages. All other end user may install on demand. And
that "only basic packages" approach will prevent missing images in
case of broken some of the additional packages.

Thanks for your work on that!

Cheers,
Piotr

2015-09-28 16:48 GMT+02:00 Comman Kang <kangxn at 163.com>:
> HiWiFi HC5661/5761/5861 models are manufactured by http://www.hiwifi.com <http://www.hiwifi.com/>. These models have similar hardware specs(MT7620A + 128M DDR2 + 16M flash). This patch adds support for them.
>
> The original author is Justin Liu (rssnsj at gmail.com). I ported the patch to trunk and submitted it here with his approval.
>
> v2 fix
>     1: Modified profile name
>     2: Merged multiple models into one manufacturer file
>     3: Some description changes
>
> Signed-off-by: Xiaoning Kang <kangxn at 163.com>
>
>
> diff --git a/target/linux/ramips/image/Makefile b/target/linux/ramips/image/Makefile
> index c24d220..372fe3b 100644
> --- a/target/linux/ramips/image/Makefile
> +++ b/target/linux/ramips/image/Makefile
> @@ -872,6 +872,9 @@ na930_mtd_size=20971520
>  Image/Build/Profile/NA930=$(call BuildFirmware/CustomFlash/$(1),$(1),na930,NA930,$(na930_mtd_size))
>  Image/Build/Profile/DB-WRT01=$(call BuildFirmware/Default8M/$(1),$(1),db-wrt01,DB-WRT01)
>  Image/Build/Profile/MZK-750DHP=$(call BuildFirmware/Default8M/$(1),$(1),mzk-750dhp,MZK-750DHP)
> +Image/Build/Profile/HC5661=$(call BuildFirmware/Default16M/$(1),$(1),hc5661,HC5661)
> +Image/Build/Profile/HC5761=$(call BuildFirmware/Default16M/$(1),$(1),hc5761,HC5761)
> +Image/Build/Profile/HC5861=$(call BuildFirmware/Default16M/$(1),$(1),hc5861,HC5861)
>  Image/Build/Profile/OY-0001=$(call BuildFirmware/Default16M/$(1),$(1),oy-0001,OY-0001)
>  Image/Build/Profile/Y1=$(call BuildFirmware/Default16M/$(1),$(1),y1,Y1)
>  Image/Build/Profile/Y1S=$(call BuildFirmware/Default16M/$(1),$(1),y1s,Y1S)
> @@ -907,6 +910,9 @@ define Image/Build/Profile/Default
>         $(call Image/Build/Profile/DB-WRT01,$(1))
>         $(call Image/Build/Profile/MZK-750DHP,$(1))
>         $(call Image/Build/Profile/NA930,$(1))
> +       $(call Image/Build/Profile/HC5661,$(1))
> +       $(call Image/Build/Profile/HC5761,$(1))
> +       $(call Image/Build/Profile/HC5861,$(1))
>         $(call Image/Build/Profile/OY-0001,$(1))
>         $(call Image/Build/Profile/Y1,$(1))
>         $(call Image/Build/Profile/Y1S,$(1))
> diff --git a/target/linux/ramips/mt7620/profiles/hiwifi.mk b/target/linux/ramips/mt7620/profiles/hiwifi.mk
> new file mode 100644
> index 0000000..3de99f3
> --- /dev/null
> +++ b/target/linux/ramips/mt7620/profiles/hiwifi.mk
> @@ -0,0 +1,49 @@
> +#
> +# Copyright (C) 2015 OpenWrt.org
> +#
> +# This is free software, licensed under the GNU General Public License v2.
> +# See /LICENSE for more information.
> +#
> +
> +define Profile/HC5661
> + NAME:=HiWiFi HC5661
> + PACKAGES:=\
> +   kmod-usb-core kmod-usb-dwc2 kmod-usb2 kmod-usb-storage  \
> +   kmod-mmc-spi kmod-sdhci kmod-sdhci-mt7620 \
> +   block-mount mountd kmod-fs-ext4 ppp-mod-pppoe e2fsprogs \
> +   kmod-ledtrig-usbdev fdisk
> +endef
> +
> +define Profile/HC5661/Description
> + Support HiWiFi HC5661 model(J1S)
> +endef
> +$(eval $(call Profile,HC5661))
> +
> +define Profile/HC5761
> + NAME:=HiWiFi HC5761
> + PACKAGES:=\
> +   kmod-usb-core kmod-usb-dwc2 kmod-usb2 kmod-usb-storage  \
> +   kmod-mmc-spi kmod-sdhci kmod-sdhci-mt7620 \
> +   block-mount mountd kmod-fs-ext4 ppp-mod-pppoe e2fsprogs \
> +   kmod-ledtrig-usbdev fdisk
> +endef
> +
> +define Profile/HC5761/Description
> + Support HiWiFi HC5761 model(J2)
> +endef
> +$(eval $(call Profile,HC5761))
> +
> +define Profile/HC5861
> + NAME:=HiWiFi HC5861
> + PACKAGES:=\
> +   kmod-usb-core kmod-usb-dwc2 kmod-usb2 kmod-usb-storage  \
> +   kmod-mmc-spi kmod-sdhci kmod-sdhci-mt7620 \
> +   block-mount mountd kmod-fs-ext4 ppp-mod-pppoe e2fsprogs \
> +   kmod-ledtrig-usbdev fdisk
> +endef
> +
> +define Profile/HC5861/Description
> +  Support HiWiFi HC5861 model(J3)
> +endef
> +$(eval $(call Profile,HC5861))
> +
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel