[OpenWrt-Devel] [PATCH] lldpd: wrap procd command args in separate quotes

[Alexandru Ardelean]

From: Alexandru Ardelean <aa at ocedo.com>

Seems the match pattern was being adapted from 'eth0' to ' eth0'
because of the way I added the procd command args.

This did not seem to be a problem when there were multiple interfaces,
just on devices with single interfaces for lldpd to listen on.

Signed-off-by: Alexandru Ardelean <ardeleanalex at gmail.com>
---
 package/network/services/lldpd/files/lldpd.init | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init
index 278dbaf..3d7d8b9 100644
--- a/package/network/services/lldpd/files/lldpd.init
+++ b/package/network/services/lldpd/files/lldpd.init
@@ -54,14 +54,14 @@ start_service() {
 	procd_set_param command /usr/sbin/lldpd
 	procd_append_param command -d # don't daemonize, procd will handle that for us
 
-	[ -n "$ifnames" ] && procd_append_param command "-I $ifnames"
+	[ -n "$ifnames" ] && procd_append_param command -I "$ifnames"
 	[ $enable_cdp -gt 0 ] && procd_append_param command '-c'
 	[ $enable_fdp -gt 0 ] && procd_append_param command '-f'
 	[ $enable_sonmp -gt 0 ] && procd_append_param command '-s'
 	[ $enable_edp -gt 0 ] && procd_append_param command '-e'
 	[ $readonly_mode -gt 0 ] && procd_append_param command '-r'
-	[ -n "$lldp_class" ] && procd_append_param command "-M $lldp_class"
-	[ -n "$lldp_description" ] && procd_append_param command "-S $lldp_description"
+	[ -n "$lldp_class" ] && procd_append_param command -M "$lldp_class"
+	[ -n "$lldp_description" ] && procd_append_param command -S "$lldp_description"
 
 	# set auto respawn behavior
 	procd_set_param respawn
-- 
2.1.4
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel