[OpenWrt-Devel] [PATCH v2] uqmi: Add proper IPv6 support

[Matti Laakso]

Hi Antti,

> Date: Thu, 17 Sep 2015 10:15:21 +0300
> Subject: Re: [OpenWrt-Devel] [PATCH v2] uqmi: Add proper IPv6 support
> From: a.seppala at gmail.com
> To: malaakso at elisanet.fi
> CC: openwrt-devel at lists.openwrt.org
> 
> On 10 September 2015 at 22:03, Matti Laakso <malaakso at elisanet.fi> wrote:
> > Use the new --ip-family option to start both IPv4 and IPv6 sessions
> > by default. Autoconnect can't be used when starting two sessions,
> > so revert back to using the client IDs and packet data handles for
> > handling the network connection.
> >
> > Some modem firmwares do not implement a RA server, therefore by
> > default use outband IP configuration and static addressing. Some
> > other firmwares report bogus IP configuration with the WDS get
> > current settings command. In this case inband configuration with
> > DHCP/RA can be optionally enabled by setting option dhcp to 1.
> >
> > Per 3GPP standard a /64 prefix is served to all clients, which is
> > extended to LAN as specified in RFC 7278.
> >
> > v2: Restrict the IPv6 gateway route source address
> > Signed-off-by: Matti Laakso <malaakso at elisanet.fi>
> 
> Hi Matti.
> 
> I built openwrt with uqmi built into the squashfs with your patch
> applied and for some reason the qmi.sh does not get execute bit when
> installed:
> 
> root at OpenWrt:~# ls -l /lib/netifd/proto/
> -rwxr-xr-x    1 root     root          2430 Sep  16 20:30 3g.sh
> -rwxr-xr-x    1 root     root          2165 Sep  16 20:30 dhcp.sh
> -rwxr-xr-x    1 root     root          3508 Sep  16 20:30 dhcpv6.sh
> -rwxr-xr-x    1 root     root          3393 Sep  16 20:30 openconnect.sh
> -rwxr-xr-x    1 root     root          6945 Sep  16 20:30 ppp.sh
> -rw-r--r--    1 root     root          6557 Sep  16 20:30 qmi.sh
> -rwxr-xr-x    1 root     root          3325 Sep  16 20:30 wwan.sh
> 
> Apparently the protocol won't then load properly. Any idea why this
> is? Applying chmod +x to the file makes the protocol work.
> 

Good catch, my patch accidentally contained an unintended mode change from 755 to 644.

> The other thing I was wondering is the tests for the new boolean
> variables with -z. E.g if there now is an explicit config directive to
> set dhcp off ("option dhcp 0") then dhcp would still be enabled.
> 
> I think the recommended design is to use something along the lines of:
> if [ "${boolean_variable:-0}" -gt 0 ]; then whatever; fi
> It looks like this should maybe apply to both dhcp and ipv6 variables?
> 

That's true with the dhcp option, but ipv6 should work correctly since it is explicitely set to "" if ipv6=0.

I'll fix both the execute bit and the dhcp option handling later today. Thanks for reporting!

Matti
 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20150917/470db574/attachment.htm>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel