[OpenWrt-Devel] [PATCH] [SIGNED-OFF] Add initial support for WeIO board

Fri Sep 11 08:51:20 EDT 2015

Hi,

On Tue, Sep 8, 2015 at 9:00 PM, Drasko DRASKOVIC
<drasko.draskovic at gmail.com> wrote:
> Subject: [PATCH] [SIGNED-OFF] Add initial support for WeIO board

Please version your patches if you change them ([PATCH V2] etc)
> Add support for WeIO board (http://we-io.net), which is based on
> Carambola2 board from 8Devices.
>
> Signed-off-by: Drasko DRASKOVIC <drasko.draskovic at gmail.com>
> ---

Please keep a changelog here about the changes between submitssions
>  target/linux/ar71xx/base-files/lib/ar71xx.sh       |   3 +
>  .../ar71xx/base-files/lib/upgrade/platform.sh      |   3 +-
>  target/linux/ar71xx/config-4.1                     |   1 +
>  .../linux/ar71xx/files/arch/mips/ath79/mach-weio.c | 145 +++++++++++++++++++++
>  target/linux/ar71xx/generic/profiles/weio.mk       |  17 +++
>  target/linux/ar71xx/image/Makefile                 |   8 ++
>  .../700-MIPS-ath79-openwrt-machines.patch          |  21 ++-

I don't see you updating etc/uci-defaults/02_network or any of the
uci-defaults files, so this won't have any proper config.

>  7 files changed, 192 insertions(+), 6 deletions(-)
>  create mode 100644 target/linux/ar71xx/files/arch/mips/ath79/mach-weio.c
>  create mode 100644 target/linux/ar71xx/generic/profiles/weio.mk
>
> diff --git a/target/linux/ar71xx/base-files/lib/ar71xx.sh b/target/linux/ar71xx/base-files/lib/ar71xx.sh
> index e1f345e..e30cac2 100755
> --- a/target/linux/ar71xx/base-files/lib/ar71xx.sh
> +++ b/target/linux/ar71xx/base-files/lib/ar71xx.sh
> @@ -832,6 +832,9 @@ ar71xx_board_detect() {
>         *"UniFi AP Pro")
>                 name="uap-pro"
>                 ;;
> +       *"WeIO")
> +               name="weio"
> +               ;;
>         *WHR-G301N)
>                 name="whr-g301n"
>                 ;;
> diff --git a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
> index c1962e4..b681fb8 100755
> --- a/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
> +++ b/target/linux/ar71xx/base-files/lib/upgrade/platform.sh
> @@ -250,7 +250,8 @@ platform_check_image() {
>         nbg460n_550n_550nh | \
>         unifi | \
>         unifi-outdoor | \
> -       carambola2 )
> +       carambola2 | \
> +       weio )
>                 [ "$magic" != "2705" ] && {
>                         echo "Invalid image type."
>                         return 1
> diff --git a/target/linux/ar71xx/config-4.1 b/target/linux/ar71xx/config-4.1
> index 21c4601..7d836d9 100644
> --- a/target/linux/ar71xx/config-4.1
> +++ b/target/linux/ar71xx/config-4.1
> @@ -139,6 +139,7 @@ CONFIG_ATH79_MACH_TL_WR941ND=y
>  CONFIG_ATH79_MACH_TUBE2H=y
>  CONFIG_ATH79_MACH_UBNT=y
>  CONFIG_ATH79_MACH_UBNT_XM=y
> +CONFIG_ATH79_MACH_WEIO=y
>  CONFIG_ATH79_MACH_WHR_HP_G300N=y
>  CONFIG_ATH79_MACH_WLAE_AG300N=y
>  CONFIG_ATH79_MACH_WLR8100=y
> diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-weio.c b/target/linux/ar71xx/files/arch/mips/ath79/mach-weio.c
> new file mode 100644
> index 0000000..791991c
> --- /dev/null
> +++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-weio.c
> @@ -0,0 +1,145 @@
> +/**
> + * WEIO Web Of Things Platform
> + *
> + * Copyright (C) 2013 Drasko DRASKOVIC and Uros PETREVSKI
> + *
> + *              ##      ## ######## ####  #######
> + *              ##  ##  ## ##        ##  ##     ##
> + *              ##  ##  ## ##        ##  ##     ##
> + *              ##  ##  ## ######    ##  ##     ##
> + *              ##  ##  ## ##        ##  ##     ##
> + *              ##  ##  ## ##        ##  ##     ##
> + *               ###  ###  ######## ####  #######
> + *
> + *                   Web Of Things Platform
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version 2
> + * of the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
> + *
> + * Authors :
> + * Drasko DRASKOVIC <drasko.draskovic at gmail.com>
> + * Uros PETREVSKI <uros at nodesign.net>
> + */
> +
> +#include <asm/mach-ath79/ath79.h>
> +#include <asm/mach-ath79/ar71xx_regs.h>
> +#include "common.h"
> +#include "dev-eth.h"
> +#include "dev-gpio-buttons.h"
> +#include "dev-leds-gpio.h"
> +#include "dev-m25p80.h"
> +#include "dev-spi.h"
> +#include "dev-usb.h"
> +#include "dev-wmac.h"
> +#include "machtypes.h"
> +#include "linux/i2c-gpio.h"
> +#include "linux/platform_device.h"
> +
> +#define WEIO_GPIO_LED_STA              1
> +#define WEIO_GPIO_LED_AP               16
> +
> +#define WEIO_GPIO_BTN_AP           20
> +#define WEIO_GPIO_BTN_RESET            23
> +
> +#define WEIO_KEYS_POLL_INTERVAL                20      /* msecs */
> +#define WEIO_KEYS_DEBOUNCE_INTERVAL    (3 * WEIO_KEYS_POLL_INTERVAL)
> +
> +#define WEIO_MAC0_OFFSET                       0x0000
> +#define WEIO_MAC1_OFFSET                       0x0006
> +#define WEIO_CALDATA_OFFSET                0x1000
> +#define WEIO_WMAC_MAC_OFFSET           0x1002

Please use tabs for indentation and align the values.

> +
> +static struct gpio_led weio_leds_gpio[] __initdata = {
> +    {
> +        .name          = "weio:green:sta",
> +        .gpio          = WEIO_GPIO_LED_STA,
> +        .active_low    = 1,
> +        .default_state = LEDS_GPIO_DEFSTATE_ON,
> +    }, {
> +        .name          = "weio:green:ap",
> +        .gpio          = WEIO_GPIO_LED_AP,
> +        .active_low    = 1,
> +        .default_state = LEDS_GPIO_DEFSTATE_ON,
> +    }
> +};

Please use tabs for indentation. The correct braces placement is
  {
  },
  {
  }

> +
> +static struct gpio_keys_button weio_gpio_keys[] __initdata = {
> +    {
> +        .desc          = "ap button",
> +        .type          = EV_KEY,
> +        .code          = BTN_0,
> +        .debounce_interval = WEIO_KEYS_DEBOUNCE_INTERVAL,
> +        .gpio          = WEIO_GPIO_BTN_AP,
> +        .active_low    = 1,
> +       },
> +    {
> +        .desc          = "soft-reset button",
> +        .type          = EV_KEY,
> +        .code          = BTN_1,
> +        .debounce_interval = WEIO_KEYS_DEBOUNCE_INTERVAL,
> +        .gpio          = WEIO_GPIO_BTN_RESET,
> +        .active_low    = 1,
> +    }
> +};