[OpenWrt-Devel] [PATCH v4] base-files: add /etc/profile.d support

Bastian Bittorf bittorf at bluebottle.com
Fri Sep 4 06:33:20 EDT 2015


* karlp <karlp at tweak.net.au> [04.09.2015 12:30]:
> > +	for FILE in /etc/profile.d/*.sh; do
> > +		[ -e "$FILE" ] && . "$FILE"
> 
> Why the -e?  You only got existing files in the glob above right? If

no, when the directory is empty, you get
FILE='/etc/profile.d/*.sh'

> Maybe "local" could be used to avoid the unset FILE line, but at least

you are right. any other comments?

bye, bastian
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list