[OpenWrt-Devel] [PATCH v2] bcm53xx: add support for Huawei WS880

[Rafał Miłecki]

On 26 November 2015 at 18:10, Prototik <me at prok.pw> wrote:
> +@@ -0,0 +1,94 @@
> ++/*
> ++ * Broadcom BCM470X / BCM5301X ARM platform code.
> ++ * DTS for Huawei WS880
> ++ *
> ++ * Copyright (C) 2015 Sergey Shatunov <me at prok.pw>
> ++ *
> ++ * Licensed under the GNU/GPL. See COPYING for details.
> ++ */
> ++
> ++/dts-v1/;
> ++
> ++#include "bcm4708.dtsi"
> ++#include "bcm5301x-nand-cs0-bch8.dtsi"
> ++
> ++/ {
> ++      compatible = "huawei,ws880", "brcm,bcm4708";
> ++      model = "Huawei WS880 (BCM4708)";
> ++
> ++      chosen {
> ++              bootargs = "console=ttyS0,115200";
> ++      };
> ++
> ++      memory {
> ++              reg = <0x00000000 0x08000000>;
> ++      };
> ++
> ++      leds {
> ++              compatible = "gpio-leds";
> ++
> ++              wlan {
> ++                      label = "bcm53xx:white:wlan";
> ++                      gpios = <&chipcommon 0 GPIO_ACTIVE_LOW>;
> ++                      linux,default-trigger = "default-on";
> ++              };
> ++
> ++              lan {
> ++                      label = "bcm53xx:white:lan";
> ++                      gpios = <&chipcommon 1 GPIO_ACTIVE_LOW>;
> ++                      linux,default-trigger = "default-on";
> ++              };
> ++
> ++              wps {
> ++                      label = "bcm53xx:white:wps";
> ++                      gpios = <&chipcommon 6 GPIO_ACTIVE_LOW>;
> ++                      linux,default-trigger = "default-on";
> ++              };
> ++
> ++              internet {
> ++                      label = "bcm53xx:white:internet";
> ++                      gpios = <&chipcommon 12 GPIO_ACTIVE_HIGH>;
> ++                      linux,default-trigger = "default-on";
> ++              };
> ++
> ++              usb {
> ++                      label = "bcm53xx:white:usb";
> ++                      gpios = <&chipcommon 14 GPIO_ACTIVE_LOW>;
> ++                      linux,default-trigger = "default-on";
> ++              };
> ++      };

Patch looks very nice in general. You just shouldn't make all LEDs
default-on. Using:
1) on for lan and internet
2) off for all other ones
would make it compatible with other DTS files for bcm53xx.

Maybe at some point we should change lan & internet to off as well and
make ethernet driver manage them. But it's a thing for separated
patch.

Would you like to resend this patch with LEDs corrected?
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel