[OpenWrt-Devel] [PATCH procd v2 08/17] ujail: remove "#include log.h" from elf.h

Etienne CHAMPETIER champetier.etienne at gmail.com
Wed Nov 25 12:54:41 EST 2015


headers must include all there dependencies, no more, no less

Signed-off-by: Etienne CHAMPETIER <champetier.etienne at gmail.com>
---
 jail/elf.c  | 1 +
 jail/elf.h  | 2 --
 jail/jail.c | 1 +
 3 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/jail/elf.c b/jail/elf.c
index 6d36215..5e22606 100644
--- a/jail/elf.c
+++ b/jail/elf.c
@@ -26,6 +26,7 @@
 #include <libubox/utils.h>
 
 #include "elf.h"
+#include "log.h"
 
 struct avl_tree libraries;
 static LIST_HEAD(library_paths);
diff --git a/jail/elf.h b/jail/elf.h
index 82cbe14..6687f3c 100644
--- a/jail/elf.h
+++ b/jail/elf.h
@@ -15,8 +15,6 @@
 #include <libubox/avl.h>
 #include <libubox/avl-cmp.h>
 
-#include "log.h"
-
 struct library {
 	struct avl_node avl;
 	char *name;
diff --git a/jail/jail.c b/jail/jail.c
index 7349a05..ae09623 100644
--- a/jail/jail.c
+++ b/jail/jail.c
@@ -28,6 +28,7 @@
 
 #include "elf.h"
 #include "capabilities.h"
+#include "log.h"
 
 #include <libubox/list.h>
 #include <libubox/uloop.h>
-- 
1.9.1
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list