[OpenWrt-Devel] [PATCH] config/Config-images.in: Fix wrong handling of ROOTFS_INCLUDE default options

Felix Fietkau nbd at openwrt.org
Wed Nov 11 09:00:50 EST 2015


On 2015-11-11 14:56, Petr Štetiar wrote:
> Felix Fietkau <nbd at openwrt.org> [2015-11-11 14:48:33]:
> 
>> This is not wrong. TARGET_ROOTFS_INCLUDE_UIMAGE depends on
>> TARGET_ROOTFS_INCLUDE_KERNEL, as it should.
> 
> Maybe it's not correct fix, but in current state it's somehow broken. If I
> revert this patch, I can't include anything (kernels, DTBs) until I select
> ext4 filesystem. Once I deselect the ext4 it lefts my config in following
> state:
> 
> 	# CONFIG_TARGET_ROOTFS_INCLUDE_KERNEL is not set
> 	CONFIG_TARGET_ROOTFS_INCLUDE_UIMAGE=y
> 	CONFIG_TARGET_ROOTFS_INCLUDE_ZIMAGE=y
> 	CONFIG_TARGET_ROOTFS_INCLUDE_FIT=y
> 	# CONFIG_TARGET_ROOTFS_INCLUDE_DTB is not set
> 
> and I'm not able to remove the included images from menuconfig anymore.
This option is apparently supported for ext4 and ubifs only. Also, the
code enabled by these options is one big design flaw, and I'd like to
get rid of it as soon as possible by converting all devices that need it
over to the new image building code.

- Felix
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list