[OpenWrt-Devel] [PATCH] bcm53xx: Add functions to get/release copies of nvram contents.

Rafał Miłecki zajec5 at gmail.com
Wed May 13 14:18:16 EDT 2015


On 13 May 2015 at 18:45, Felix Fietkau <nbd at openwrt.org> wrote:
> On 2015-05-13 09:48, Hante Meuleman wrote:
>> Initially I made the free an inline from header file, but it doesn't compile
>> out of the box as it needs the definition for kfree and not all c files which
>> include this header file had this, as I don't like the inclusion of header
>> files from header files I choose to make an implementation in the c file.
> I don't understand your reasons at all. How does it make more sense to
> make the code more bloated instead of placing a simple #include
> statement (which doesn't cost anything)?

I agree with Felix, I don't think there is anything forbidden about
including header in a header :)

-- 
Rafał
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list