[OpenWrt-Devel] ddns default config values broken?

[Henning Schild]

Looking at the code the script is already pretty complicated for what it
does. So i would say forget about the traffic it will generate, because
it is close to nothing already. Just keep it simple.

If you still decide to implement an increase, there should be a
maximum of say 10 times the original retry interval. If your wan fails
and comes back after hours the script might have reached a very high
sleep time and will not update the records for a long time, not to
mention wrapping numbers that might cause funny behaviour.

Reading the code i found it very confusing that the verbosity level is
abused to derive whether the scripts runs in loop- or one-shot- mode.
That should be another command line parameter and a new variable in the
script. But that is a totally different issue, and certainly a matter
of style that can be argued about.

Henning

On Sat, 09 May 2015 19:09:32 +0200
Christian Schoenebeck <christian.schoenebeck at gmail.com> wrote:

> Hi Henning,
> 
> the pull request is posted on github
> https://github.com/openwrt/packages/pull/1241 Please have a look on
> the comments. What do you think about a minimum or increasing sleep
> time before next retry ?
> 
> Christian
> 
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel