[OpenWrt-Devel] [PATCHv2] scripts/feeds: observe -p flag for preferential feeds

Karl Palsson karlp at tweak.net.au
Tue Jun 23 05:51:00 EDT 2015


Karl Palsson <karlp at tweak.net.au> wrote:
> > John Crispin <blogic at openwrt.org> wrote:
> > > On 27/05/2015 18:03, Karl Palsson wrote:
> > > > +	my $this_feed_target = lookup_target($feed, $name);
> > > > +	$this_feed_target and do {
> > > 
> > > how about just calling it $target ?
> > 
> > Because even though the method is "lookup_target" it actually returns a
> > feed for the target $name.
> > 
> > I could change the method to lookup_feed_for_target too, if that would
> > help.
> 
> Is anything else needed here?  Would be nice to get this fixed before
> it's branched.
> 

Anything?  It now should be backported to CC as well, given that this is
documented behaviour of scripts/feeds that's regressed.

Sincerely,
Karl Palsson
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list