[OpenWrt-Devel] [PATCHv2] ppp : Unnumbered support

[Bastian Bittorf]

* Hans Dedecker <dedeckeh at gmail.com> [12.06.2015 12:15]:
> +		if [ -n "$res_mask" -a "$mask" != 32 ]; then
> +			[ "$mask" -gt "$res_mask" ] || [ "$res_mask" = 32 ] && {

if you send a v3, please use here:
[ "$mask" -gt "$res_mask" -o "$res_mask" = 32 ] && {
...
}

> +		[ -n "$localip" ] || {

here please use ("dont use negation of negation"):

[ -z "$localip" ] && {
...
}

bye, bastian
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel