[OpenWrt-Devel] [PATCH 3/3] ppp: Unnumbered support

[Steven Barth]

Thanks, I already applied the other two.


On 10.06.2015 10:39, Hans Dedecker wrote:
> +ppp_select_ipaddr()
> +{
> +	local interface="$1"
> +	local addrs=$(uci_get "network.${interface}.ipaddr")
> +	local netmask=$(uci_get "network.${interface}.netmask")
Any particular reason you are reading from UCI here and do not use the
interface status parsing via e.g. network_get_subnets from
/lib/functions/network.sh? This would seem more clear to me and would
avoid the awkward parsing of netmasks as well. Additionally this would
make it work with non-static protos as well.


Cheers,

Steven
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel