[OpenWrt-Devel] [PATCH RFC] Add support for Ubiquiti Unifi Outdoor Plus

[Arjen de Korte]

Citeren Kirill Berezin <kyb22 at rol.ru>:

> Hi Stefan,
>
> I have a couple of suggestions.
>
> First of all I think it will be better to initialize static  
> variables in hsr_tune with zeroes :
>
>> ++static void hsr_tune(struct ath_hw* ah, int bw, int fq) {
>> ++	static int initialized = 0;
>> ++	static int last_bw = 0, last_fq = 0;

These static variables will be initialized to zero anyway, so the  
above is redundant (but may be clearer to read). See  
http://www.open-std.org/JTC1/SC22/WG14/www/docs/n1256.pdf, §6.7.8  
sub-paragraph 10.
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel