[OpenWrt-Devel] [PATCH RFC] brcmfmac: register wiphy(s) during module_init

Rafał Miłecki zajec5 at gmail.com
Mon Jun 1 06:53:21 EDT 2015


On 1 June 2015 at 00:08, Rafał Miłecki <zajec5 at gmail.com> wrote:
> @@ -440,6 +441,7 @@ static void brcmf_fw_request_nvram_done(const struct firmware *fw, void *ctx)
>         }
>
>         fwctx->done(fwctx->dev, fwctx->code, nvram, nvram_length);
> +       complete(&fwctx->completion);
>         kfree(fwctx);
>         return;
>

Hey Rafał, it's unsafe to call complete and free the struct right
after. Do it smarter.
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list