[OpenWrt-Devel] [PATCH] procd: reorder the arguments of command invocations

Felix Fietkau nbd at openwrt.org
Sun Jan 11 07:13:45 EST 2015


On 2015-01-10 18:54, Gianluca Anzolin wrote:
> Some commands in the script /lib/upgrade/nand.sh (provided by
> procd) use option arguments after non-option arguments.
> 
> This unfortunately doesn't work with musl because it doesn't yet support
> permutations of the arguments: when getopt finds a non-option argument
> it returns -1 and ignores any option which may follow.
> 
> One visible side effect is that sysupgrade doesn't work with musl/NAND
> tarballs.
> 
> The following patch reorders the command invocations by placing the
> options before any non-option argument.
> 
> Tested on a Netgear WNDR4300 built with ubifs support and musl libc.
> 
> Signed-off-by: Gianluca Anzolin <gianluca at sottospazio.it>
It seems that musl git now supports argv permutation. I'm going to merge
the git changes since the last release soon.

- Felix
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list