[OpenWrt-Devel] [PATCH 2/2] lantiq: ltq-vdsl-app: cleanup Makefile

Mathias Kresin openwrt at kresin.me
Fri Dec 11 10:27:54 EST 2015


- CONFIG_IFX_CLI is unused, couldn't find any reference to this config variable
- use disable-feature instead of enable-feature=no
- reorder configure args to have depending args together
- remove configure args which set the default value
- group enable-model and configure args which enable or disable features that
  are covered by the feature set

The config.log contains the same values as before. The vdsl_cpe_control binary
has the same checksum as before.

Signed-off-by: Mathias Kresin <openwrt at kresin.me>
---
 package/network/config/ltq-vdsl-app/Makefile | 22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/package/network/config/ltq-vdsl-app/Makefile b/package/network/config/ltq-vdsl-app/Makefile
index fffe894..bfacccd 100644
--- a/package/network/config/ltq-vdsl-app/Makefile
+++ b/package/network/config/ltq-vdsl-app/Makefile
@@ -34,31 +34,25 @@ define Package/ltq-vdsl-app/description
 endef
 
 CONFIGURE_ARGS += \
-	--with-max-device="1" \
-	--with-lines-per-device="1" \
-	--with-channels-per-line="1" \
 	--enable-vrx \
+	--enable-vrx-device=vr9 \
 	--enable-driver-include="-I$(STAGING_DIR)/usr/include/drv_vdsl_cpe_api" \
 	--enable-device-driver-include="-I$(STAGING_DIR)/usr/include/vdsl/" \
-	--enable-add-appl-cflags="-DMAX_CLI_PIPES=1"  \
 	--enable-ifxos \
 	--enable-ifxos-include="-I$(STAGING_DIR)/usr/include/ifxos" \
 	--enable-ifxos-library="-I$(STAGING_DIR)/usr/lib" \
-	--enable-dsl-ceoc=no \
-	--enable-vrx-device=vr9 \
-	--disable-dti \
+	--enable-add-appl-cflags="-DMAX_CLI_PIPES=1"  \
 	--enable-debug \
-	--enable-dsl-pm-showtime
-
-ifeq ($(CONFIG_IFX_CLI),y)
-CONFIGURE_ARGS += \
-	--enable-cli-support
-endif
+	--disable-dti \
+	--with-channels-per-line="1" \
 
 #CONFIGURE_ARGS += --enable-model=full
 #CONFIGURE_ARGS += --enable-model=lite
 #CONFIGURE_ARGS += --enable-model=footprint
-CONFIGURE_ARGS += --enable-model=typical
+CONFIGURE_ARGS += \
+	--enable-model=typical \
+	--enable-dsl-pm-showtime \
+	--disable-dsl-ceoc
 #CONFIGURE_ARGS += --enable-model=debug
 
 define Package/ltq-vdsl-app/install
-- 
1.9.1
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list