[OpenWrt-Devel] [PATCH 1/1] [polarssl] Fix build failures due to PKG_NAME != dir name

[Daniel Dickinson]

On 2015-08-12 12:21 AM, Yousong Zhou wrote:
> On 11 August 2015 at 10:00, Yousong Zhou <yszhou4tech at gmail.com> wrote:
>> On 2 August 2015 at 19:46, Daniel Dickinson
>> <openwrt at daniel.thecshore.com> wrote:
>>> Packages that depend on PolarSSL fail to build because polarssl's InstallDev
>>> section never actually gets executed because (prior to this patch) the package
>>> name does not match the subdir the package is in (presumably due to upstream
>>> name change).  As a workaround I have changed the package name back to
>>> polarssl and used a new variable SRC_PKG_NAME for the purposes of downloading
>>> the upstream tarball and creating PKG_BUILD_DIR.
>>>
>>
>> Nice catch, but only setting PKG_BUILD_DIR should be enough to fix
>> this.  No need to introduce a new variable.
>>
>
> Hello, Daniel
>
> After a second look on the code, I didn't get why there was a problem.
> Anyway, openvpn-polarssl built and run fine in my environment.
>

It occurred for me on trunk (build failure of curl with ca-certficates 
package enabled; when I checked staging_dir/usr/include the polarssl 
header was missing and make package/polarssl/{clean,compile,install} 
failed to add it to staging_dir).

Have said that, my current build of the Chaos Calmer branch without the 
patch has not had an issue, so at this point I don't know if there was 
some local issue or there has been a problem introduced in trunk.

Also note that simply not getting an error message during build is 
insufficient to verify the issue since the issue only occurs if there 
happens to be a configure option (like ca-certificates) that cannot work 
without ssl actually compiled in because non-ssl versions of curl and 
openvpn are valid build configurations and it may be configure will 
silently build the non-ssl version if it can't find the ssl library.

To be sure you need to get ldd onto the router, or otherwise verify that 
the build actually linked against polarssl.

Regards,

Daniel
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel