[OpenWrt-Devel] [PATCH] Ar71xx: Add Minibox v1.0 support

[Karl Palsson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Stijn Segers <francesco.borromini at inventati.org> wrote:
> Hi Karl,
> 
> Thanks for your time.
> 
> I have reworked the patch and re-ordered where possible (files like 
> ar71xx.sh and diag.sh lack any alphabetical
> order). I have removed the code that set the led to status_led_off. 
> What file should I be looking at, when you talk
> about the board file? Is it the minibox-v1.mk file? I diffed from the 
> vendor's code (and added a profile by comparing
> with other devices) but that was it.

I meant target/linux/ar71xx/files/arch/mips/ath79/mach-minibox-v1.c

> 
> I don't have the hardware myself but I have found a tester willing to 
> run the image (and see how the LED behaves with
> the default OpenWrt settings).

It's not relevant how it behaves for them on their board.  My problem
here was that you were changing the behaviour for _all_ boards.  And by
the sound of it, you were working around an active low/high
misconfiguration, which should be addressed by properly configuring the
polarity of the leds in your board file,
target/linux/ar71xx/files/arch/mips/ath79/mach-minibox-v1.c

> 
> 
> The new patch can be found here:
> 
> https://volatilesystems.org/dl/openwrt/targets/add-minibox-target-trunk.patch
> 
> If that doesn't work, a backup: http://sprunge.us/AUbX

No-one's looking at that.  I'm being helpful by reviewing your earlier
mangled patch, but if you want this to be applied, you _will_ need to
follow https://dev.openwrt.org/wiki/SubmittingPatches 
Pay particular attention to item 6.  Yes, this is the graybeard stone
age, lowest common denominator of email behaviour, but those are the
_rules_ I recommend git-send-email to avoid the mangling that most clients will do.

I expect the problem here: https://patchwork.ozlabs.org/patch/505479/
was that you trying to use diff manually to generate the patch set (from
your .orig directory)  While I'm sure that's possible, there's a reason
most people use git or svn.

Cheers,
Karl P

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBAgAGBQJVzJtSAAoJEBmotQ/U1cr2WT4QALzDtq4XEBLaooi/Bu8qr+WI
83MRsoZHHd6GzEq+x8+2P07vPqrOHu6xbKGgx34KbAj4W6YXAUme8HYRm0/rIoYm
PnJj5xJzn/JOkQbUU21+Fj+mXFEKWAyNC0byjmzFRIeo7viMSUCuPfU6NPm+aQua
iDDj4iZTbgtPVRdBWAu6glBSLFajrS35PFbcLOfX1bvJ/ci930PWymfSWgY0bH+0
AyXzHcRbfM/apf09e3VxicfzmFCWLYMkAdStjPXKuok3hXom7E7gk6iMHE5j9B0A
JxTBlahs+yoi4A0eEEGQs+D5+hisFzXB0mbGHqTBmpGyXFzo21V4sZfb00UrGtVx
h1lcXKAU3IC4MVRm0I3/Ef0LCBeDCW1w/yNNBt/X4POGPm1ZUYl8B3z27/1AX6M9
/B4f35/A0g1X2sQLv4fZppJVbOhoxlgpxEo+Ms7TgVX/ERTUbN/n37b37UQg6frA
MIG5OWHK+9HQk7NYXFvQWoW/jBLfU2HLR9ki1AUJtEfNQpYtOxJjZcF1SMlA46/0
aPUYbu/NObBYpA2CtheJuzb8MgeeE6QQs4D8Ik6de5NeBrO93XCe2nkJg9XCLkM/
a1uCq4R+p35nAq7Vrb94V/LjQasxwIOzJpSVMmAWIjQb8H5j6iYtwJlONrJCQGq2
WtF+/zcBO3X9fFVnlM7Q
=zcDx
-----END PGP SIGNATURE-----
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel