[OpenWrt-Devel] [PATCHv2 netifd 2/3] bridge: Allow setting multicast_to_unicast option

[Linus Lüssing]

On Wed, Aug 05, 2015 at 01:38:28PM +0200, Felix Fietkau wrote:
> On 2015-08-05 01:00, Linus Lüssing wrote:
> > With this patch the multicast_to_unicast feature can be disabled for all
> > wireless interfaces via an according option on the uci bridge interface.
> > 
> > This patch also exports the setting information to wireless handler
> > scripts. The hostapd script will need that information to determine
> > whether to enable or disable ap-isolation, for instance.
> > 
> > Signed-off-by: Linus Lüssing <linus.luessing at c0d3.blue>
> I think it would be better to store these flags in the bridge config
> instead of the generic device config, and either add a blob_buf argument
> in struct device_hotplug_ops -> prepare, or add a new callback get_info,
> which adds the bridge info for use in the wireless json.

These would then be options per bridge, but not per bridge port,
wouldn't they?

For the multicast_to_unicast feature, okay (currently this patch
only allows setting it "globally" for a bridge but not on a bridge
port basis - though I was thinking about maybe making it bridge
port specific once someone needs that). For the multicast_router
option I'd need that on a bridge port basis.

> 
> I would like to avoid polluting the generic device options with bridge
> specific stuff.
> 
> This patch should probably be merged with the previous one afterwards,
> since the first one without any other changes will cause regressions.

Regressions, where/why? If this patch were ommitted from this
patchset then no harm should be done (unless I'm missing
something?).

Cheers, Linus
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel