[OpenWrt-Devel] [PATCH 01/11] ar71xx: use a common naming scheme for LEDS on wnr2000-v4

Michael J. Bazzinotti bazz at cs.umb.edu
Mon Apr 20 19:24:12 EDT 2015


From: "Michael J. Bazzinotti" <mbazzinotti at gmail.com>

It is common that the router provider be used rather than product name.
One can see this in target/linux/ar71xx/base-files/etc/uci-defaults/01_leds

Signed-off-by: Michael J. Bazzinotti <mbazzinotti at gmail.com>
---
 .../linux/ar71xx/base-files/etc/uci-defaults/01_leds   | 14 +++++++-------
 .../ar71xx/files/arch/mips/ath79/mach-wnr2000-v4.c     | 18 +++++++++---------
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/target/linux/ar71xx/base-files/etc/uci-defaults/01_leds b/target/linux/ar71xx/base-files/etc/uci-defaults/01_leds
index 787523a..559ff5b 100644
--- a/target/linux/ar71xx/base-files/etc/uci-defaults/01_leds
+++ b/target/linux/ar71xx/base-files/etc/uci-defaults/01_leds
@@ -498,13 +498,13 @@ wlae-ag300n)
 	;;
 
 wnr2000-v4)
-	ucidef_set_led_netdev "wan" "WAN" "wnr2000-v4:green:wan" "eth1"
-	ucidef_set_led_netdev "wlan" "WLAN" "wnr2000-v4:blue:wlan" "wlan0"
-	ucidef_set_led_switch "lan1" "LAN1" "wnr2000-v4:amber:lan1" "switch0" "0x04"
-	ucidef_set_led_switch "lan2" "LAN2" "wnr2000-v4:amber:lan2" "switch0" "0x08"
-	ucidef_set_led_switch "lan3" "LAN3" "wnr2000-v4:amber:lan3" "switch0" "0x10"
-	ucidef_set_led_switch "lan4" "LAN4" "wnr2000-v4:amber:lan4" "switch0" "0x02"
-	ucidef_set_led_usbdev "usb" "USB" "wnr2000-v4:amber:status" "1-1"
+	ucidef_set_led_netdev "wan" "WAN" "netgear:green:wan" "eth1"
+	ucidef_set_led_netdev "wlan" "WLAN" "netgear:blue:wlan" "wlan0"
+	ucidef_set_led_switch "lan1" "LAN1" "netgear:amber:lan1" "switch0" "0x04"
+	ucidef_set_led_switch "lan2" "LAN2" "netgear:amber:lan2" "switch0" "0x08"
+	ucidef_set_led_switch "lan3" "LAN3" "netgear:amber:lan3" "switch0" "0x10"
+	ucidef_set_led_switch "lan4" "LAN4" "netgear:amber:lan4" "switch0" "0x02"
+	ucidef_set_led_usbdev "usb" "USB" "netgear:amber:status" "1-1"
     ;;
 
 wzr-hp-ag300h)
diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2000-v4.c b/target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2000-v4.c
index d8437dc..36896b7 100644
--- a/target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2000-v4.c
+++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2000-v4.c
@@ -52,44 +52,44 @@
 
 static struct gpio_led wnr2000v4_leds_gpio[] __initdata = {
 	{
-		.name		= "wnr2000-v4:green:power",
+		.name		= "netgear:green:power",
 		.gpio		= WNR2000V4_GPIO_LED_PWR_GREEN,
 		.active_low	= 1,
         .default_trigger = "default-on",
 	}, {
-		.name		= "wnr2000-v4:green:wan",
+		.name		= "netgear:green:wan",
 		.gpio		= WNR2000V4_GPIO_LED_WAN_AMBER,
 		.active_low	= 1,
 	},
 	{
-		.name		= "wnr2000-v4:green:wps",
+		.name		= "netgear:green:wps",
 		.gpio		= WNR2000V4_GPIO_LED_WPS,
 		.active_low	= 1,
 	},
 	{
-		.name		= "wnr2000-v4:amber:status",
+		.name		= "netgear:amber:status",
 		.gpio		= STATUS_LED_GPIO,
 		.active_low	= 1,
 	},
 	{
-		.name		= "wnr2000-v4:blue:wlan",
+		.name		= "netgear:blue:wlan",
 		.gpio		= WNR2000V4_GPIO_LED_WLAN,
 		.active_low	= 1,
 	},
 	{
-		.name		= "wnr2000-v4:amber:lan1",
+		.name		= "netgear:amber:lan1",
 		.gpio		= WNR2000V4_GPIO_LED_LAN1,
 		.active_low	= 1,
 	}, {
-		.name		= "wnr2000-v4:amber:lan2",
+		.name		= "netgear:amber:lan2",
 		.gpio		= WNR2000V4_GPIO_LED_LAN2,
 		.active_low	= 1,
 	}, {
-		.name		= "wnr2000-v4:amber:lan3",
+		.name		= "netgear:amber:lan3",
 		.gpio		= WNR2000V4_GPIO_LED_LAN3,
 		.active_low	= 1,
 	}, {
-		.name		= "wnr2000-v4:amber:lan4",
+		.name		= "netgear:amber:lan4",
 		.gpio		= WNR2000V4_GPIO_LED_LAN4,
 		.active_low	= 1,
 	}
-- 
1.9.1
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list