[OpenWrt-Devel] [PATCH] ar71xx: uThing support - take II
Karl Palsson
karlp at tweak.net.au
Sat Apr 11 09:34:56 EDT 2015
There's a few places here where things are sorted alphabetically.
You've added the uthing beside the dragino2, presumably because it's
based on the dragino2-HE module? Still, it's just another ar9331 board,
so please keep the lists sorted.
Further, the board patch lists it as being based on the RIO700? Which
is it?
Further, you still have // comments as mentioned earlier.
You've added _new_ files with copyright year of 2011. This cannot be
correct. (target/linux/ar71xx/generic/profiles/uthing.mk)
Sincerely,
Karl Palsson
Lars Boegild Thomsen <lth at bright-things.com> wrote:
> Adding OpenWrt support for the uThing module.
>
> Sorry for earlier mistakes. I think they have all been fixed, except I
> am still a bit confused about the "subject line".
>
> Signed-off-by: Lars Boegild Thomsen <lth at bright-things.com>
>
full patch elided
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
More information about the openwrt-devel
mailing list