[OpenWrt-Devel] [PATCH] ramips: fix device-trees for AsiaRF awm002/3 evb

John Crispin blogic at openwrt.org
Wed Sep 17 03:46:50 EDT 2014



On 17/09/2014 09:42, Russell Senior wrote:
>>>>>> "John" == John Crispin <blogic at openwrt.org> writes:
> 
> John> On 17/09/2014 09:24, Russell Senior wrote:
>>> It also enables GPIO control of the second GPIO controller, in 
>>> rt5350.dtsi, but does not use it.
> 
> John> that is why it is not enabled by default :)
> 
> It could be used, which I did while testing.  I don't understand
> the logic of disabling the second gpio controller for everyone
> that includes rt5350.dtsi.  I don't understand the harm.  Can you
> elaborate please?
> 
> 

if a router uses the 2nd gpio core it can enable it inside its own dts
file. if the gpio core is not used then it does not need to be
enabled. its like loading a wifi driver for a wifi card that does not
get used. it will just eat up memory and power.

we could argue whether it makes sense or not i guess, maybe a matter
of personal taste .. for the sake of consistency i would like to keep
it this way.

	John
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list