[OpenWrt-Devel] Please could somebody implement this short term [OpenWrt] #18018: luci-app-ddns is missing the event interface option

[Christian Schoenebeck]

Am 03.10.2014 um 12:24 schrieb Jo-Philipp Wich:
> Whats the meaning of this option?
> 
> The description text is awful and since I do not know what it is
> supposed to do I cannot write a proper one.
> 
> Also a signed-off-by would be good.
> 
> ~ Jow
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
> 
Hi Jow,

The original code in luci-0.11 used for AA12.09 is your code.
The code inside luci-0.12 and luci-trunk was changed in 2013 by Manuel Munz <freifunk at somakoma dot de>
What happened in the meanwhile with the code, I don't know.
I only copy 3 lines of code from 0.11 to 0.12.

The (re)attached patch, brings back the event interface to luci-app-ddns.
Without "option interface" set, ddns-scripts will never work.
Without setting the event interface, a user using LuCi WebUI has no chance 
to use Dynamic DNS without hack the config from console,
because the ddns-scripts behind it will not work.

Signed-off-by: Christian Schoenebeck <christian.schoenebeck at gmail.com>

---

Index: applications/luci-ddns/luasrc/model/cbi/ddns/ddns.lua
===================================================================
--- applications/luci-ddns/luasrc/model/cbi/ddns/ddns.lua	(Revision 10533)
+++ applications/luci-ddns/luasrc/model/cbi/ddns/ddns.lua	(Arbeitskopie)
@@ -26,6 +26,10 @@
 
 s:option(Flag, "enabled", translate("Enable"))
 
+interface = s:option(ListValue, "interface", translate("Event interface"), translate("On which interface up should start the ddns script process."))
+luci.tools.webadmin.cbi_add_networks(interface)
+interface.default = "wan"
+
 svc = s:option(ListValue, "service_name", translate("Service"))
 svc.rmempty = false
 svc.default = "dyndns.org"

-------------- next part --------------
A non-text attachment was scrubbed...
Name: openwrt_ticket_18018.patch
Type: text/x-diff
Size: 690 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20141003/6302589c/attachment.bin>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel