[OpenWrt-Devel] ar8216: question regarding ar8xxx_phy_config_aneg

[Heiner Kallweit]

In my tests with AR8327 this callback was never called with an addr != 0.
Seems logical to me as it's called for the PHY attached to the net device
only.

In most cases this is addr 0, just for AR8316 with port4_phy being set this
could be 4.

This leads to two questions:

1. The current version of this function checks for "addr == 0" always, I'd
assume this is not correct for AR8316 and port4_phy being set.

2. As it seems to be called for the attached PHY addr only and in exactly
this case we do nothing: Can we simply replace this callback with a dummy
"return 0" ?

Heiner
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20141128/e2bcbffa/attachment.htm>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel