[OpenWrt-Devel] [PATCH] package/boot/uboot-envtools: retry uci-defaults for fw_env.config

[John Crispin]

Hi,

On 27/10/2014 14:53, Tijs Van Buggenhout wrote:
> -[ -s /etc/config/ubootenv ] && exit 0 +FWC="/etc/fw_env.config" 
> +UC="/etc/config/ubootenv"
> 
> -touch /etc/config/ubootenv +[ -s $FWC -a -s $UC ] && exit 0
> 

this bit is redundant between all calling files. can you no move it to
the start of uboot-envtools.sh ? that would also safe you the extra {}
that you add in various files.

i marked v1 and v2 as changes requested in patchwork

	John
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel