[OpenWrt-Devel] [PATCH 1/4] [WEIO] Adding WeIO profile

[Drasko DRASKOVIC]

On Mon, Jun 30, 2014 at 2:09 PM, John Crispin <john at phrozen.org> wrote:
> Hi,
>
> please resend with the patches inline, it is not possible to comment
> when they are attached.

No problem, I will be re-sending the patches inline.

>
> also, my first impression is that the patches are really messy and the
> commit text only partially matches what is inside the patches.
>
> 1/4 seems to have a pile of unrelated white space fixes.
>
> 1/4 adds a file only for 2/4 and 3/4 to "fix it"

Yes, this might be true, as this was my development process. Should
these be squashed then?

>
> 4/4 adds code with incorrect indenting

Yes, this should be fixed

>
> this is all not bad and we can fix it, however for that to be possible
> you need to send the patches inline.
>
> using git send-email is the best way to do so.

Will do this.

>
> last but not least, this is a carambola2 carrier board, with a lpc uC on
> it ? is this the uC that had a usb device stack in firmware ?

WeIO is based on Carambola2 module, but has some changes - like
different GPIOs for buttons and leds, some other peripherals, etc...

LPC uC has USB stack in the FW, and the all the FW can be found here:
https://github.com/8devices/UPER

Best regards,
Drasko
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel