[OpenWrt-Devel] [RFC netifd] Out-of-sync reference counter causes seg. fault

[Felix Fietkau]

On 2014-06-29 23:10, Kristian Evensen wrote:
> Hi Felix,
> 
> On Sun, Jun 29, 2014 at 8:36 PM, Felix Fietkau <nbd at openwrt.org> wrote:
>> Please test the latest version and check if that hack is still necessary.
> 
> Thanks for your reply. I tested with latest netifd and latest libubus,
> to make sure that I got the reload-fixes. The issue is unfortunately
> still present. I see that I forgot to reference the commit that
> introduced this seg. fault, it is
> 7233afd94910cb4583c9555840a990287fd5d642. When reverting this commit,
> I no longer see the crash.
Thanks for the info about the commit that broke it, now this issue 
makes more sense to me. Please try this patch:

---
--- a/interface.c
+++ b/interface.c
@@ -509,8 +509,8 @@ interface_cleanup_state(struct interface *iface)
 	interface_clear_errors(iface);
 	interface_set_proto_state(iface, NULL);
 
-	if (iface->main_dev.dev)
-		interface_set_main_dev(iface, NULL);
+	interface_set_main_dev(iface, NULL);
+	interface_set_l3_dev(iface, NULL);
 }
 
 static void
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel