[OpenWrt-Devel] [Patch][BCM63XX][V2][RFC] Select HW_RANDOM_BCM63XX only in the SoCs that support it.

[Jonas Gorski]

On Wed, Jun 18, 2014 at 5:34 PM, José Vázquez Fernández
<ppvazquezfer at gmail.com> wrote:
> Select HW_RANDOM_BCM63XX only in the SoCs that support it.
>
> Only BCM6368, BCM6362 and BCM63268 have a hardware random numbers
> generator, so, if none of these are selected, don't compile it.
>
> Tested with BCM6358 and BCM6328 successfully with both 3.10 and 3.14
> kernels.
>
> Signed off by: José Vázquez Fernández <ppvazquezfer at gmail.com>

Sorry, I still don't see the point of this. All this patch does is
slightly reduce the visibility of HW_RANDOM_BCM63XX. And since this is
a user selectable symbol, I don't think this makes much sense because
if you don't want it built, you can just not select it.

Also, COMPILE_TEST should only be added if it actually compiles for
other arches (or even different mips targets), which it doesn't.


Jonas
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel