[OpenWrt-Devel] [PATCH 12/23] ar71xx: refresh 451-gpio-74x164-improve-platform-device-support.patch

[Zhao, Gang]

On Sat, 2014-07-26 at 08:44:57 +0200, John Crispin wrote:
> On 26/07/2014 08:30, John Crispin wrote:
>> 
>> 
>> On 26/07/2014 04:48, Zhao, Gang wrote:
>>> --	if (!spi->dev.of_node) { --		dev_err(&spi->dev, "No device
>>> tree data available.\n"); +	pdata = spi->dev.platform_data; +	np
>>> = spi->dev.of_node; + +	if (!np && !pdata) { +
>>> dev_err(&spi->dev, "No configuration data available.\n");
>> 
>> 
>> Hi,
>> 
>> these patches are not refreshes but you actually change the code
>> path.
>> 
>> please resend the whole series with proper annotations inside the 
>> various patch descriptions and subjects.
>> 
>> John
>
>
> ok, apparently i had not finished my coffee when reading the patches ...
>
> i am not entirely sure if copying the patches and then fixing them 1
> by 1 is the best idea really. lets see what others have to say ...
>
That's the way how i did it, and it didn't totally succeed, i.e., the
PHY doesn't work correctly for now on 3.14 kernel. But this way may be
easier than scratch from uptream vanilla kernel. I will post the full
boot message, in case someone is interested in the PHY problem.
>
>
>
>> _______________________________________________ openwrt-devel
>> mailing list openwrt-devel at lists.openwrt.org 
>> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
>> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel