[OpenWrt-Devel] [PATCH 0/4] fix rb532 support

Roman Yeryomin leroi.lists at gmail.com
Sun Jul 6 18:47:26 EDT 2014


On 6 July 2014 18:08, Felix Fietkau <nbd at openwrt.org> wrote:
> On 2014-07-06 13:17, Roman Yeryomin wrote:
>> On 6 July 2014 01:20, Roman Yeryomin <leroi.lists at gmail.com> wrote:
>>> On 5 July 2014 18:03, Felix Fietkau <nbd at openwrt.org> wrote:
>>>> On 2014-07-05 00:35, Roman Yeryomin wrote:
>>>>> This patch set fully fixes rb532 support and removes broken mark.
>>>>>
>>>>> Roman Yeryomin (4):
>>>>>   [rb532] fix jffs2 images
>>>>>   [rb532] change default package set
>>>>>   [rb532] add wan interface
>>>>>   [rb532] remove broken mark
>>>> What about squashfs images? It looks to me like one of your patches
>>>> which was applied in r40717 tried to fix them but actually left them in
>>>> a broken state - the cmdline mounts squashfs directly on sda2 instead of
>>>> going through block2mtd.
>>>
>>> Yes, that's sounds weird to me also now but they work like that for me.
>>> I will check that again tomorrow.
>>
>> So, squashfs works both ways. But the older squashfs cmdline was
>> broken anyway as it was using mtdblock0 (like jffs2).
>> I can add a patch to change squashfs to using block2mtd again, if you
>> want, but I don't see any reasons to do that.
> Are you sure that it actually mounts the jffs2 overlay? I'd expect it to
> come up with tmpfs the way it's implemented right now.

You, were right, I didn't look at that before (I just used ext4 images).
Please see the patch attached. I don't know if this hack is acceptable
but I don't see any other way to fix it.
The key point is that we have to rename the onboard flash partition to
make splitting work (without introducing other split methods?). This,
potentially, can break something elsewhere but I don't see where right
now.

Regards,
Roman
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-rb532-really-fix-squashfs-images.patch
Type: text/x-patch
Size: 2223 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20140707/733d716f/attachment.bin>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list